Add functions thread-unsafe in Ubuntu 26.04#8598
Merged
Merged
Conversation
Collaborator
|
hmm.. in #5086 you added some tests. Would it be possible to improve the tests? |
Contributor
Author
|
On Tue, 2 Jun 2026, Daniel Marjamäki wrote:
danmar left a comment (cppcheck-opensource/cppcheck#8598)
hmm.. in #5086 you added some tests. Would it be possible to improve the tests?
--
Reply to this email directly or view it on GitHub:
#8598 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
Hmm.
I see that I didn't integrate them into the pytest system used for other
addons. I can look at addons/test/y2038_test.py and make a
addons/test/threadsafety_test.py that does something similar.
Beyond that I don't know what else I might want to test.
I've discovered that
man elf_flagelf
lists more MT-Unsafe functions than tools/MT-Unsafe.py found,
so have an update for that script and the unsafe list.
…--
Not strictly related to #8598:
https://sourceforge.net/p/cppcheck/discussion/general/thread/209919289c/
strerror has been MT-Safe since glibc 2.32 (Aug 2020)
so I am thinking of removing strerror from the unsafe list.
This will mean changing the test in test/cli/other_test.py too
(CI spotted that !)
I'll make these all separate PRs unless you suggest otherwise.
--
Andrew C. Aitchison Kendal, UK
***@***.***
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two new? thread-unsafe functions were found in Ubuntu 26.04 "Resolute Raccoon":
Add these to addons/threadsafety.py